search

biocore / metagenomics_pooling_notebook

Jupyter notebooks to assist with sample processing
MIT License
8 stars 16 forks source link

User-defined well_description now working correctly. #121

Closed charles-cowart closed 1 year ago

charles-cowart commented 1 year ago

Previously, make_sample_sheet() would ignore 'Well_description' if it was defined in the input table and instead would generate the column from sample-name values.

This fix will allow 'Well_description' values to reflect as intended when using make_sample_sheet() and accept 'description' and 'well_description' as alternatives in the input table as well.

Code-review confirmed that 'Well_description' is no longer used to obtain the sample-name in metapool.

charles-cowart commented 1 year ago

Note that I preserved the legacy behavior of _remap_table() by setting the new optional parameter 'strict' to equal True. After confirming all occurrences of _remap_table() work correctly with setting strict=False, we can opt to remove the strict variable and the legacy behavior.