biocore / metagenomics_pooling_notebook

Jupyter notebooks to assist with sample processing
MIT License
8 stars 16 forks source link

Change pre-prep file column names #149

Closed charles-cowart closed 9 months ago

charles-cowart commented 9 months ago

well_id_386 is now well_id_96 destination_well_id is now well_id_386

RodolfoSalido commented 9 months ago

well_id_386 should be well_id_384, but maybe this just a typo.

-Rodolfo

On Oct 11, 2023, at 1:26 PM, Charles Cowart @.***> wrote:

well_id_386 is now well_id_96 destination_well_id is now well_id_386

You can view, comment on, or merge this pull request online at:

https://github.com/biocore/metagenomics_pooling_notebook/pull/149 https://github.com/biocore/metagenomics_pooling_notebook/pull/149 Commit Summary

a26f88d https://github.com/biocore/metagenomics_pooling_notebook/pull/149/commits/a26f88d664b489b6b01cb77e9b9de8fe9da52c09 Change pre-prep file column names File Changes (7 files https://github.com/biocore/metagenomics_pooling_notebook/pull/149/files) M metapool/prep.py https://github.com/biocore/metagenomics_pooling_notebook/pull/149/files#diff-3818143e9469f17ef1884ebfd0c5213f590155c9c9ee0ff3dc3f27dc54e709c8 (2) M metapool/tests/data/bad_pre_prep.csv https://github.com/biocore/metagenomics_pooling_notebook/pull/149/files#diff-5d63622d13c8b428bc59b397d0edf64a03c850b195cdfb99817216393bca5ef1 (2) M metapool/tests/data/pre_prep_w_replicates.csv https://github.com/biocore/metagenomics_pooling_notebook/pull/149/files#diff-835087031baba44bb5eb9d6cded1c836074fe799a428a50df3c669e8913add38 (2) M metapool/tests/data/pre_prep_wo_replicates.csv https://github.com/biocore/metagenomics_pooling_notebook/pull/149/files#diff-bf1224394dabe4482f42fe70d9a56b8e94282c92cba179d0f3249294ef29728c (2) M metapool/tests/data/replicate_output5.txt https://github.com/biocore/metagenomics_pooling_notebook/pull/149/files#diff-8a2479a3c9fc59727839104ea0fd20bdd9d531aff52c533513f0e143186f268c (2) M metapool/tests/data/replicate_output6.txt https://github.com/biocore/metagenomics_pooling_notebook/pull/149/files#diff-a95de619e79592e75fee851d13e605a74eff1eccfb7ad72867a4c3faffca7cf7 (2) M metapool/tests/data/replicate_output7.txt https://github.com/biocore/metagenomics_pooling_notebook/pull/149/files#diff-26de93b37b27d266322ae81dfec9b27160c30aa3add96e4b51710fe595ddf6f3 (2) Patch Links:

https://github.com/biocore/metagenomics_pooling_notebook/pull/149.patch https://github.com/biocore/metagenomics_pooling_notebook/pull/149.patch https://github.com/biocore/metagenomics_pooling_notebook/pull/149.diff https://github.com/biocore/metagenomics_pooling_notebook/pull/149.diff — Reply to this email directly, view it on GitHub https://github.com/biocore/metagenomics_pooling_notebook/pull/149, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADEVFIZOIRY6QDFBXKUTYI3X636JDANCNFSM6AAAAAA54R5WFA. You are receiving this because you are subscribed to this thread.

charles-cowart commented 9 months ago

well_id_386 should be well_id_384, but maybe this just a typo.

Thanks Rodolfo! Yes, it's just a typo in the description. I just reviewed all of the changes in the PR and the code changes properly reflect _384.