search

biocore / metagenomics_pooling_notebook

Jupyter notebooks to assist with sample processing
MIT License
8 stars 16 forks source link

Ensure TRUE/FALSE is caught when validating sample-sheets. #188

Open charles-cowart opened 3 months ago

charles-cowart commented 3 months ago

Sample-sheets must now use 'True' or 'False' explicitly. Ensure validation catches this so that processing doesn't begin before this error is caught (ValueError: 'TRUE' is not a valid value for BarcodesAreRC).

ackermag commented 1 week ago

This is a real problem for people generating the sample_sheets who want to check that they are correctly formatted because the default viewer is Excel. Excel will automatically convert any version of true and false to TRUE and FALSE with central justification in the cell. In order to correct this, the SRA/processor of data needs to remember to convert to 'True' and 'False'. Why can't the code accept any version of true and false.

charles-cowart commented 1 week ago

This is a real problem for people generating the sample_sheets who want to check that they are correctly formatted because the default viewer is Excel. Excel will automatically convert any version of true and false to TRUE and FALSE with central justification in the cell. In order to correct this, the SRA/processor of data needs to remember to convert to 'True' and 'False'. Why can't the code accept any version of true and false.

We used to be able to do this, but Daniel and Rob asked that I remove it. @wasade, I've been getting frequent requests to let True and False be case in-sensitive. If someone uses Excel to make a manual correction in a sample-sheet, it will instantly become invalid because Excel implicitly converts all forms of true and false to TRUE and FALSE. Would you mind if this made a comeback?