search

biocore / metagenomics_pooling_notebook

Jupyter notebooks to assist with sample processing
MIT License
8 stars 16 forks source link

Add support for parsing sample sheets with empty lines #21

Closed ElDeveloper closed 2 years ago

ElDeveloper commented 2 years ago

Turns out this is a valid format, but since we support comments we needed to add a check there. Already was documented here: https://github.com/clintval/sample-sheet/issues/46

charles-cowart commented 2 years ago

@ElDeveloper merged code failed testing in the new Github CI. I'll revert for now. The nature of this error escapes me: https://github.com/biocore/metagenomics_pooling_notebook/runs/3653593683?check_suite_focus=true#step:9:38

charles-cowart commented 2 years ago

@ElDeveloper confirmed coveralls tests succeeded, and your changes are in the lastest master. We should be good with this one.

ElDeveloper commented 2 years ago

Thanks so much!

On Sep 21, 2021, at 2:29 PM, Charles Cowart @.***> wrote:

@ElDeveloper confirmed coveralls tests succeeded, and your changes are in the lastest master. We should be good with this one.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.