biocore / metagenomics_pooling_notebook

Jupyter notebooks to assist with sample processing
MIT License
8 stars 16 forks source link

Centralize constants defining sequencers #234

Open AmandaBirmingham opened 2 months ago

AmandaBirmingham commented 2 months ago

KLSampleSheet's _add_data_to_sheet() method includes literals defining the available sequencers:

        sequencer_types = ['novaseq', 'hiseq', 'miseq', 'miniseq', 'iseq']

However, there are also lists of strings defining sequencers in the REVCOMP_SEQUENCERS and OTHER_SEQUENCERS module-level list variables in metapool.metapool. The lists in the two modules are doing slightly different things, but there's a good chance that if the list(s) in one module changes, the list(s) in the other could need to be modified as well; I would feel a lot safer if they were either turned into a single data structure or at least all defined next to each other so we are reminded to always deal with them together.