Closed AmandaBirmingham closed 4 days ago
charles-cowart
commented
4 days ago I just added a small comment on Restarting and Clearing all output on notebooks before committing changes so that we can observe differentials. Otherwise changes look good. I got some ideas on writing tests from the additional CI tests in this PR.
Not sure what that means exactly. Is it all right to merge it into master or should I hold off? It looks like we have a conflict that needs to be resolved in any case.
RodolfoSalido
commented
4 days ago Sorry for confusion/ambiguity. Changes look good and I think it’s safe to merge.
My comment pertains to modifications to jupyter notebooks. Committing changes to jupyter notebooks should happen after testing it and Restarting Kernel and Clearing all output from notebook so that the module run numbers are cleared and GitHub can generate a differential.
-Rodolfo
On Thu, Nov 14, 2024 at 12:09 PM Charles Cowart @.***> wrote:
I just added a small comment on Restarting and Clearing all output on notebooks before committing changes so that we can observe differentials. Otherwise changes look good. I got some ideas on writing tests from the additional CI tests in this PR.
Not sure what that means exactly. Is it all right to merge it into master or should I hold off?
— Reply to this email directly, view it on GitHub https://github.com/biocore/metagenomics_pooling_notebook/pull/244#issuecomment-2477316010, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADEVFIYZEKAP2NRN25EMYPT2AT7RNAVCNFSM6AAAAABP75WGDKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINZXGMYTMMBRGA . You are receiving this because your review was requested.Message ID: @.***>
fix https://github.com/biocore/metagenomics_pooling_notebook/issues/241
I spent another half hour in the lab this morning fighting a notebook error caused by leading zeroes (fyi, our heuristic of pasting a zero on to the front of the tube codes in the accession files fails when we get a barcode that is already full-length--10 digits--and thus does not NEED a leading zero \<smh>). This madness must stop :D
Nonetheless, because leading zeroes are such a persistent pain, I expect even switching over to stripping them may cause issues somewhere. Therefore I have added the optional ability to preserve them (keep the current behavior) so we have a safety valve if something blows up.