search

biocore / metagenomics_pooling_notebook

Jupyter notebooks to assist with sample processing
MIT License
8 stars 16 forks source link

Bclconvert #44

Closed charles-cowart closed 2 years ago

charles-cowart commented 2 years ago

Added support for reading Reports/Demultiplex_Stats.csv files generated by bcl-convert.

charles-cowart commented 2 years ago

@ElDeveloper I'm not sure why this failed build. It's referencing bad syntax in stock nosetests code. Nosetests are successful for me locally. Do you have an idea what it might be?

charles-cowart commented 2 years ago

Hi @ElDeveloper! Thanks so much for your patience. I believe these most recent changes should address your comments and concerns.

charles-cowart commented 2 years ago

Thanks @ElDeveloper! I put my rationale for using 'or' instead of 'and', but I can go either way (no pun intended). Let me know what you think. I made the other changes you requested. Thanks again for reviewing this PR!

ElDeveloper commented 2 years ago

Thanks so much @charles-cowart

charles-cowart commented 2 years ago

Thanks so much @ElDeveloper !