search

biocore / metagenomics_pooling_notebook

Jupyter notebooks to assist with sample processing
MIT License
8 stars 16 forks source link

Negative concentrations from SpectraMax_i3x reader output break normalization functions. #57

Closed RodolfoSalido closed 1 year ago

RodolfoSalido commented 2 years ago

New plate reader can output negative concentrations for samples with really low nucleic acid yields. The negative values break various normalization functions in the notebook.

Fix is to change read_pico_csv() to limit concentrations to a range of (0,60).

antgonza commented 2 years ago

Thank you @RodolfoSalido; how ofter does this happen and how urgent is this?

RodolfoSalido commented 2 years ago

It happens often and we believe this could be the cause of some of the metagenomics library prep issues we have been experiencing. I am submitting a pull request with the fix that I suggest but my GitHub maintenance is not as god as it should be :/

-Rodolfo

On Dec 6, 2021, at 2:58 PM, Antonio Gonzalez @.***> wrote:

Thank you @RodolfoSalido https://github.com/RodolfoSalido; how ofter does this happen and how urgent is this?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/biocore/metagenomics_pooling_notebook/issues/57#issuecomment-987333341, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADEVFI72QMLESTQRHAO7SBDUPU5YRANCNFSM5JPZ2J2A. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

RodolfoSalido commented 2 years ago

should be fixed by #58