search

biocore / metagenomics_pooling_notebook

Jupyter notebooks to assist with sample processing
MIT License
8 stars 16 forks source link

Update error text for parsing run ID #66

Closed wasade closed 2 years ago

wasade commented 2 years ago

cc @ElDeveloper

ElDeveloper commented 2 years ago

Looks good, thanks! Can you add a test for that exception? Otherwise looks good to go. Thanks so much for addressing so promptly! 😃

wasade commented 2 years ago

A test was added in #65 to assert parsing of an iSeq run ID, is there a different test that should be added here?

ElDeveloper commented 2 years ago

Yes, I was thinking about a test that checks for the correct exception error message depending on the malformed input.

ElDeveloper commented 2 years ago

Thanks so much!