biocore / metagenomics_pooling_notebook

Jupyter notebooks to assist with sample processing
MIT License
8 stars 16 forks source link

Input norm + dilution plate functions? #84

Closed DrCletusSpucklerMD closed 1 year ago

DrCletusSpucklerMD commented 1 year ago

Hello Developers!

We've been having to dilute our gDNA plates a lot recently and would like the following line of code to be added to Section 2.5 Step 4 of the metagenomics_pipeline_MiniPiconorm notebook:

Screen Shot 2022-10-28 at 12 39 27 AM

The technicians have been adding this line in by hand but it would be nice to codify it. It allows us to feed in a dilution plate into the echo in addition to the sample and water plates.

Many thanks! . . .

Also on the topic of dilution plates - the input norm transfer file generated by the format_dna_norm_picklist function currently spits out a file that looks like this with the water transfers on top:

Screen Shot 2022-10-28 at 12 42 09 AM

If it could spit a file with the DNA additions prior the water additions, that would allow the wetlab technicians to visually check that all the DNA actually transfered prior to initiating the water transfer. It's a nice QC. Pretty sure all you need to do is flip the order of these two code snippets:

Screen Shot 2022-10-28 at 12 59 46 AM

Many many many thanks, Helena T.

RodolfoSalido commented 1 year ago

Hello I discussed this with Helena.

We will be testing which Source Plate order is optimal for DNA Input Normalization.

Once we come to a a decision, I can make the necessary changes to the repository and do a pull request.

Thanks, Rodolfo

On Oct 28, 2022, at 1:02 AM, DrCletusSpucklerMD @.***> wrote:

Hello Developers!

We've been having to dilute our gDNA plates a lot recently and would like the following line of code to be added to Section 2.5 Step 4 of the metagenomics_pipeline_MiniPiconorm notebook:

https://user-images.githubusercontent.com/22571541/198531559-11636ae7-313d-45ce-9c99-24a4b0c2315b.png The technicians have been adding this line in by hand but it would be nice to codify it. It allows us to feed in a dilution plate into the echo in addition to the sample and water plates.

Many thanks! . . .

Also on the topic of dilution plates - the input norm transfer file generated by the format_dna_norm_picklist function currently spits out a file that looks like this with the water transfers on top:

https://user-images.githubusercontent.com/22571541/198532067-300117e4-3107-4731-8aaa-203d3a1888a3.png If it could spit a file with the DNA additions prior the water additions, that would allow the wetlab technicians to visually check that all the DNA actually transfered prior to initiating the water transfer. It's a nice QC. Pretty sure all you need to do is flip the order of these two code snippets:

https://user-images.githubusercontent.com/22571541/198535721-31f9cd8a-628c-4c32-9e6a-73ff2b52d3d2.png Many many many thanks, Helena T.

— Reply to this email directly, view it on GitHub https://github.com/biocore/metagenomics_pooling_notebook/issues/84, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADEVFI25OKQ45NCMSA6O4NLWFOB7RANCNFSM6AAAAAARQ2BIZU. You are receiving this because you are subscribed to this thread.

DrCletusSpucklerMD commented 1 year ago

Thanks for helping guide me through this Github "Issues" process here, Rodolfo! I didn't know Github "Issues" existed and got a little overzealous trying to find a use for it! Exciting.

Thank you both, Helena

On Fri, Oct 28, 2022 at 1:31 PM RodolfoSalido @.***> wrote:

Hello I discussed this with Helena.

We will be testing which Source Plate order is optimal for DNA Input Normalization.

Once we come to a a decision, I can make the necessary changes to the repository and do a pull request.

Thanks, Rodolfo

On Oct 28, 2022, at 1:02 AM, DrCletusSpucklerMD @.***> wrote:

Hello Developers!

We've been having to dilute our gDNA plates a lot recently and would like the following line of code to be added to Section 2.5 Step 4 of the metagenomics_pipeline_MiniPiconorm notebook:

< https://user-images.githubusercontent.com/22571541/198531559-11636ae7-313d-45ce-9c99-24a4b0c2315b.png> https://urldefense.com/v3/__https://user-images.githubusercontent.com/22571541/198531559-11636ae7-313d-45ce-9c99-24a4b0c2315b.png*3E__;JQ!!Mih3wA!CPqiyDH4-A4h-aSM9J4lwvrG5joISQ1CSOgCCvckTxaBh8-bmoYEMGnjGsPbXJ_fHOcEc-BIfLW0Kge0oPr_wHA$ The technicians have been adding this line in by hand but it would be nice to codify it. It allows us to feed in a dilution plate into the echo in addition to the sample and water plates.

Many thanks! . . .

Also on the topic of dilution plates - the input norm transfer file generated by the format_dna_norm_picklist function currently spits out a file that looks like this with the water transfers on top:

< https://user-images.githubusercontent.com/22571541/198532067-300117e4-3107-4731-8aaa-203d3a1888a3.png> https://urldefense.com/v3/__https://user-images.githubusercontent.com/22571541/198532067-300117e4-3107-4731-8aaa-203d3a1888a3.png*3E__;JQ!!Mih3wA!CPqiyDH4-A4h-aSM9J4lwvrG5joISQ1CSOgCCvckTxaBh8-bmoYEMGnjGsPbXJ_fHOcEc-BIfLW0Kge06Tbfpn4$ If it could spit a file with the DNA additions prior the water additions, that would allow the wetlab technicians to visually check that all the DNA actually transfered prior to initiating the water transfer. It's a nice QC. Pretty sure all you need to do is flip the order of these two code snippets:

< https://user-images.githubusercontent.com/22571541/198535721-31f9cd8a-628c-4c32-9e6a-73ff2b52d3d2.png> https://urldefense.com/v3/__https://user-images.githubusercontent.com/22571541/198535721-31f9cd8a-628c-4c32-9e6a-73ff2b52d3d2.png*3E__;JQ!!Mih3wA!CPqiyDH4-A4h-aSM9J4lwvrG5joISQ1CSOgCCvckTxaBh8-bmoYEMGnjGsPbXJ_fHOcEc-BIfLW0Kge0m_BN56A$ Many many many thanks, Helena T.

— Reply to this email directly, view it on GitHub < https://github.com/biocore/metagenomics_pooling_notebook/issues/84> https://urldefense.com/v3/__https://github.com/biocore/metagenomics_pooling_notebook/issues/84*3E__;JQ!!Mih3wA!CPqiyDH4-A4h-aSM9J4lwvrG5joISQ1CSOgCCvckTxaBh8-bmoYEMGnjGsPbXJ_fHOcEc-BIfLW0Kge0czst8hI$, or unsubscribe < https://github.com/notifications/unsubscribe-auth/ADEVFI25OKQ45NCMSA6O4NLWFOB7RANCNFSM6AAAAAARQ2BIZU> https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/ADEVFI25OKQ45NCMSA6O4NLWFOB7RANCNFSM6AAAAAARQ2BIZU*3E__;JQ!!Mih3wA!CPqiyDH4-A4h-aSM9J4lwvrG5joISQ1CSOgCCvckTxaBh8-bmoYEMGnjGsPbXJ_fHOcEc-BIfLW0Kge0BMwOWJo$ . You are receiving this because you are subscribed to this thread.

— Reply to this email directly, view it on GitHub https://urldefense.com/v3/__https://github.com/biocore/metagenomics_pooling_notebook/issues/84*issuecomment-1295436398__;Iw!!Mih3wA!CPqiyDH4-A4h-aSM9J4lwvrG5joISQ1CSOgCCvckTxaBh8-bmoYEMGnjGsPbXJ_fHOcEc-BIfLW0Kge0lMPLfmc$, or unsubscribe https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AFMGUFLYH6FEQQ2UCFHJ7LLWFQZ2DANCNFSM6AAAAAARQ2BIZU__;!!Mih3wA!CPqiyDH4-A4h-aSM9J4lwvrG5joISQ1CSOgCCvckTxaBh8-bmoYEMGnjGsPbXJ_fHOcEc-BIfLW0Kge04AtEdtQ$ . You are receiving this because you authored the thread.Message ID: @.***>

antgonza commented 1 year ago

Just to keep everyone on the same page, @charles-cowart (thank you!) issued a PR solving this: https://github.com/biocore/metagenomics_pooling_notebook/issues/84. @RodolfoSalido / @DrCletusSpucklerMD , could you take a look/review? Thank you.