search

biocore / micronota

annotation pipeline for microbial genomes and metagenomes
BSD 3-Clause "New" or "Revised" License
18 stars 10 forks source link

MinCED wrapper #51

Closed tkosciol closed 8 years ago

tkosciol commented 8 years ago

I added MinCED wrapper and created tests for it.

mortonjt commented 8 years ago

:+1: Don't forget to update the CHANGELOG to mention that we now have the minced wrapper.

@RNAer want to review this before merging?

RNAer commented 8 years ago

Thanks, @tkosciol ! It looks good. Besides the minor comments inline, why are there changes in the files of hmmer and infernal folder?

tkosciol commented 8 years ago

@RNAer thanks! About changes in hmmer and infernal - I don't know how they got there. There is just some version issue between my repo and micronota master. It's just that I don't know how to remove those files selectively from a pull request, sorry.:/

mortonjt commented 8 years ago

Those files were automagically merged in from the previous PR. Given that the tests are passing, I think it is OK.

RNAer commented 8 years ago

nope. those files are never tracked before. I don't think we should add random files.

RNAer commented 8 years ago

:+1: Thanks, @tkosciol !