biocore / micronota

annotation pipeline for microbial genomes and metagenomes
BSD 3-Clause "New" or "Revised" License
18 stars 10 forks source link

signalP integration #61

Open tkosciol opened 8 years ago

tkosciol commented 8 years ago

signalP integration and tests

RNAer commented 8 years ago

have u heard anything back from SignalP people?

tkosciol commented 8 years ago

Unfortunately not. I will write a follow-up.

t.

On 15 Mar, 2016, at 4:05 PM, Zech Xu notifications@github.com<mailto:notifications@github.com> wrote:

have u heard anything back from SignalP people?

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHubhttps://github.com/biocore/micronota/pull/61#issuecomment-197062156

tkosciol commented 8 years ago

I got a response saying that my request was forwarded to someone else. I hope they get back to me within a couple of days.

tkosciol commented 8 years ago

I reached out SignalP people for the 4th time on Thursday (Apr 7). I'd suggest that we consider our options within their license if we don't hear from them by Thursday Apr 14.

RNAer commented 8 years ago

the generated png files are not unit tested, right? Let's only include the files that's required by the tests.

tkosciol commented 6 years ago

guess this PR is obsolete now. should we just close it?