GFF format parser and tests

biocore / micronota

annotation pipeline for microbial genomes and metagenomes

BSD 3-Clause "New" or "Revised" License

18 stars 10 forks source link

GFF format parser and tests #70

Open tkosciol opened 8 years ago

mortonjt commented 8 years ago

Looking good! And don't forget to address the pep8/flake8 errors .

coveralls commented 8 years ago

Coverage increased (+0.3%) to 86.07% when pulling 77b60e9273dbe5c81e8debe0c4ba1dde473722b3 on tkosciol:gff into 976ff939bdbccc27ac1e642cdaab85d274f419b4 on biocore:master.

RNAer commented 8 years ago

if I am correct, the generator yield a IntervalMetadata for each row? it should be a IntervalMetadata for each SEQID.

coveralls commented 8 years ago

Coverage increased (+0.7%) to 86.434% when pulling 81e1bfdaffc78ca8045a963ebeffc3eb287bffd8 on tkosciol:gff into 976ff939bdbccc27ac1e642cdaab85d274f419b4 on biocore:master.

tkosciol commented 8 years ago

@gff.writer coming tomorrow!

coveralls commented 8 years ago

Coverage increased (+0.5%) to 86.257% when pulling eb50ce154aaca926e60a29586cecb08c450b1815 on tkosciol:gff into 976ff939bdbccc27ac1e642cdaab85d274f419b4 on biocore:master.

RNAer commented 8 years ago

done with review. and usually there is no motivation to start the variable names inside a function with _, as they are already local variables.

coveralls commented 8 years ago

Coverage decreased (-3.7%) to 82.08% when pulling c849ef9f1aa50504b0d9286306b7e02932cbe8c2 on tkosciol:gff into 976ff939bdbccc27ac1e642cdaab85d274f419b4 on biocore:master.

RNAer commented 8 years ago

some comments are still left unaddressed...

tkosciol commented 6 years ago

this PR is obsolete too. close?