Split sequence - Githubissues

biocore / microprot

structural annotation pipeline for microbial genomes and metagenomes

BSD 3-Clause "New" or "Revised" License

1 stars 6 forks source link

Split sequence #31

Closed sjanssen2 closed 7 years ago

sjanssen2 commented 7 years ago

addressing issue #4

coveralls commented 7 years ago

Coverage increased (+0.3%) to 94.164% when pulling bdcde26857d16a616909d77f6b5b42d0708783bb on sjanssen2:split_sequence into 19098c1932a8a414ac2c87fd413c05cb4f6e455f on biocore:master.

tkosciol commented 7 years ago

great! I will review it later.

coveralls commented 7 years ago

Coverage increased (+0.4%) to 94.29% when pulling 13674a5e9d437b03fe54591148b475d8f9518f9c on sjanssen2:split_sequence into 19098c1932a8a414ac2c87fd413c05cb4f6e455f on biocore:master.

coveralls commented 7 years ago

Coverage increased (+0.8%) to 94.615% when pulling 087f7df7ff6c4ac669b0adb26e6adf28d50bf4e4 on sjanssen2:split_sequence into 19098c1932a8a414ac2c87fd413c05cb4f6e455f on biocore:master.

coveralls commented 7 years ago

Coverage increased (+0.9%) to 94.721% when pulling f836364b142730a6f0d59ea91924e63e5d0ada80 on sjanssen2:split_sequence into 19098c1932a8a414ac2c87fd413c05cb4f6e455f on biocore:master.

sjanssen2 commented 7 years ago

I changes the return such that you get two lists (match and non-match), but it is still only one fasta file that is written by the function. Do you need two?

tkosciol commented 7 years ago

yes, it would be great to have consistent behaviour between the two. let me know when it's ready for review. I've been looking at it and so far it looks good!

sjanssen2 commented 7 years ago

@tkosciol done!

coveralls commented 7 years ago

Coverage increased (+0.9%) to 94.784% when pulling 5ea6aa06646dfd72d731cedf26fa6004ddd698d3 on sjanssen2:split_sequence into 19098c1932a8a414ac2c87fd413c05cb4f6e455f on biocore:master.

tkosciol commented 7 years ago

looks good on a first look. Will do an in-depth review a bit later. In the meantime, @qiyunzhu could you also take a look at it?

coveralls commented 7 years ago

Coverage increased (+0.9%) to 94.776% when pulling 7729b0163bcf1f65fae6f098933114bd6a78c711 on sjanssen2:split_sequence into 19098c1932a8a414ac2c87fd413c05cb4f6e455f on biocore:master.

qiyunzhu commented 7 years ago

Hi @sjanssen2 thanks for modification! All look good to me. May I click merge? @tkosciol

coveralls commented 7 years ago

Coverage increased (+0.9%) to 94.776% when pulling e8da54860712aaec5429d9c5009bcd496cc3212b on sjanssen2:split_sequence into 19098c1932a8a414ac2c87fd413c05cb4f6e455f on biocore:master.