search

biocore / microprot

structural annotation pipeline for microbial genomes and metagenomes
BSD 3-Clause "New" or "Revised" License
1 stars 6 forks source link

updated split_search #37

Closed tkosciol closed 7 years ago

tkosciol commented 7 years ago

solving issues #33 #34 and #35

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.2%) to 93.39% when pulling 53eaf48163c9148f546ceb857263ed2120733309 on split_search into 58116c3ea9182831673ea257613031d4d0a73abb on master.

tkosciol commented 7 years ago

should I just remove pass from pretty_output instead? I thought it's customary in Python to have some sort of return value in each function.

sjanssen2 commented 7 years ago

I don't know the best pythonic practice, but I find it confusing. If there is no return value then just remove the "pass", please.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.09%) to 93.53% when pulling 420d662196c06aaae727c35c83a884e236b5389b on split_search into 58116c3ea9182831673ea257613031d4d0a73abb on master.

sjanssen2 commented 7 years ago

Is it too much to ask you for adding more unit-tests to cover those 11 missed lines of code?

tkosciol commented 7 years ago

I ain't doing tests for click, because it's difficult and it doesn't make much sense, i.e. click uses mask_sequence function and pretty_output, both of which are tested. Are you cool with that?

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.6%) to 94.247% when pulling 1e9c8aeaad7bce662d5027f710dff379e4a071d9 on split_search into 58116c3ea9182831673ea257613031d4d0a73abb on master.