search

biocore / microprot

structural annotation pipeline for microbial genomes and metagenomes
BSD 3-Clause "New" or "Revised" License
1 stars 6 forks source link

adding additional unit tests to cover Tomasz pseudo bug, i.e. a bit u… #44

Closed sjanssen2 closed 7 years ago

sjanssen2 commented 7 years ago

…nexpected behaviour Addressing Issue #42 by adding more tests

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.08%) to 93.979% when pulling b0c5b9aba001f0fbb480f0ab63629ec2fe2ef4e6 on sjanssen2:nonbug into d5975f002f3d800f13c6d41e03ac7ead7e208885 on biocore:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.1%) to 94.007% when pulling 93201f8c46d62279f912a48a8a53c89fc25a01ae on sjanssen2:nonbug into d5975f002f3d800f13c6d41e03ac7ead7e208885 on biocore:master.

tkosciol commented 7 years ago

so we're not changing the behavior to request file name, instead of folder name? e.g. -o /path/to/folder/ would write: /path/to/folder.match and /path/to/folder.non_math, instead of, say, raising an error?

unit tests look good.

sjanssen2 commented 7 years ago

it is kind of a design decision. I would prefer to keep it as is, unless you have more convincing arguments to change than "we are too stupid to use it" :-)

tkosciol commented 7 years ago

OK, makes sense!