biocore / microprot

structural annotation pipeline for microbial genomes and metagenomes
BSD 3-Clause "New" or "Revised" License
1 stars 6 forks source link

added calculate Neff script #47

Closed qiyunzhu closed 7 years ago

qiyunzhu commented 7 years ago

Hello @tkosciol @sjanssen2 I have created this code in response to issue #26 .

I am not 100% certain the calculation is correct. Please review the code with your scientific mind. Specifically, what I noticed that could be problems are:

The actual code is very simple and can be compressed in five lines. The reason I created so many functions is because I guess other parts of the program may want to call some of these functions.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.3%) to 94.573% when pulling 89f44f4847c282997d9fac5e5f7a34f69a3a044a on qiyunzhu:process into 2410216bc2f4adcf51e1efc5b17fe0d9a2805281 on biocore:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.3%) to 94.595% when pulling 301b22907c576c2d6c8ec9d33a1d27c53e7020e0 on qiyunzhu:process into 2410216bc2f4adcf51e1efc5b17fe0d9a2805281 on biocore:master.

tkosciol commented 7 years ago

Looks good to me! @sjanssen2 any comments? In the interest of time I want to leave it with Hamming distance for now and I'll keep an issue open, so that we know to upgrade this script later.

sjanssen2 commented 7 years ago

That's fine to me :thumbsup:

qiyunzhu commented 7 years ago

Thank you guys! @tkosciol @sjanssen2