Closed qiyunzhu closed 7 years ago
Looks good to me! @sjanssen2 any comments? In the interest of time I want to leave it with Hamming distance for now and I'll keep an issue open, so that we know to upgrade this script later.
That's fine to me :thumbsup:
Thank you guys! @tkosciol @sjanssen2
Hello @tkosciol @sjanssen2 I have created this code in response to issue #26 .
I am not 100% certain the calculation is correct. Please review the code with your scientific mind. Specifically, what I noticed that could be problems are:
-
) are treated as the 21st character, which may result in the overestimation of number of clusters.scipy
's hierarchical clustering function. Not sure if it's the desired way.The actual code is very simple and can be compressed in five lines. The reason I created so many functions is because I guess other parts of the program may want to call some of these functions.