search

biocore / microprot

structural annotation pipeline for microbial genomes and metagenomes
BSD 3-Clause "New" or "Revised" License
1 stars 6 forks source link

Fix split #73

Closed sjanssen2 closed 6 years ago

sjanssen2 commented 6 years ago

Fixed #71 Hit name is identified as start of line up to number that reports hit coordinates. Problem arises if this number is suffix of the name. We need to start the line from back to front, not front to back!

sjanssen2 commented 6 years ago

ready for a review @tkosciol The Travis error is nothing I touched, did we ignore it before?

tkosciol commented 6 years ago

Travis error looks safe to ignore. this was the case before, too and we had no problems. So, basically the only difference is changing find to rfind - wow!

Looks good, thanks @sjanssen2 !!!

sjanssen2 commented 6 years ago

@qiyunzhu am I right that the code that flake8 is complaining about (ambiguous variables) is of your production? Should you feel bored in China, you could do me a favor and clean that up. But it is really not urgent. Thanks.

qiyunzhu commented 6 years ago

@sjanssen2 The code did pass flake8 when I produced it. Maybe there is some new standard? Should I pull biocore:master and fix and pull request?

qiyunzhu commented 6 years ago

@sjanssen2 I just pulled master and tested with flake8 locally. It didn't complain...