biocore / microprot

structural annotation pipeline for microbial genomes and metagenomes
BSD 3-Clause "New" or "Revised" License
1 stars 6 forks source link

added ability to filter matching hits for min sequence identity #74

Closed sjanssen2 closed 4 years ago

sjanssen2 commented 6 years ago

addressing feature request #72

sjanssen2 commented 6 years ago

I haven't actually tested the click function. I think we don't have unit tests for this in place, right?

sjanssen2 commented 6 years ago

@tkosciol besides testing click this PR is good for review.

tkosciol commented 6 years ago

@sjanssen2 you're the best! really appreciate your quick response on these!

Qiyun had some click testing functionality, e.g. in https://github.com/biocore/microprot/blob/master/microprot/tests/test_process_fasta.py I will just pull the PR and make some evaluations on a set of known inputs. If it's okay, I will merge. I've got some jobs to run, like, right now.