Open wasade opened 3 years ago
@gwarmstrong, can you take this?
What is the priority of this vs. sample highlighting on empress?
Also, it might make more sense for @dhakim87 to do the plotting work since it is all in plotly and I think he is more familiar. I have not actually used it before.
This could probably be split into two issues, one for language fixes and the other for the plotting.
Higher priority. Can the empress stuff be handed to Kalen or Yoshiki?
Additional comments from Justin
- i suggest to hyphenate all instances of alpha-diversity and beta-diversity
- i suggest to replace instances of 'compute' and 'computing' with 'calculate' and 'calculating', for consistency
- i suggest to add axes labels to the figure
- in the plots, i suggest to change 'me' to 'you'
Can the empress stuff be handed to Kalen or Yoshiki?
The primary blocker is a new endpoint on the public API that returns a sample's features in a format that matches the the collapsed taxonomy for the empress endpoint.
Okay thanks. It might be nice to get some other developers familiar with modifying that codebase?
It might be nice to get some other developers familiar with modifying that codebase?
Agreed. Though I am not sure https://github.com/biocore/microsetta-public-api/issues/100 would be the best starting point for a developer new to the project, since it requires a decent understanding of the code base and the task is a little open ended.
Fair, perhaps a good for pair programming target?
On Mar 5, 2021, at 9:37 AM, George Armstrong notifications@github.com wrote:
It might be nice to get some other developers familiar with modifying that codebase?
Agreed. Though I am not sure biocore/microsetta-public-api#100 https://github.com/biocore/microsetta-public-api/issues/100 would be the best starting point for a developer new to the project, since it requires a decent understanding of the code base and the task is a little open ended.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/biocore/microsetta-interface/issues/94#issuecomment-791572728, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADTZMRQCO5HLI2OMGLJJSDTCEJD3ANCNFSM4YUJMPHA.
The verbiage like “compute” and “Evolutionary breadth” is very technical sounding and can be simplified. Also reduce the number of times that “compute” is used.
No one understands the chart. Can this be switched to showing histograms? Can the tools on the image be removed? Specific comments: