search

biocore / microsetta-private-api

A private microservice to support The Microsetta Initiative
BSD 3-Clause "New" or "Revised" License
6 stars 19 forks source link

Extend test db to include a made-up kit with unassigned sample(s) and put its kit name in yaml as example #82

Open dhakim87 opened 4 years ago

dhakim87 commented 4 years ago

YAML example fills in a kit name that has no available samples in the test database. We need to be ready to give them a kit_name they can use to play with samples so they can build out this part of their UI. Seems unnecessary as a yaml change, can send it along in their instructions, but putting it in the yaml wouldn't hurt either.

AmandaBirmingham commented 4 years ago

Resolution: 1) Short-term: identify a kit name in the existing ag_test database that has unassigned sample(s). Communicate this kit name to Departure (NOT via the github project, but as a separate email/etc) as what to use when testing claiming a sample for a source, etc. 2) Long-term: Add a test kit with unclaimed samples to the test database. Change yaml example kit name to be this.

AmandaBirmingham commented 4 years ago

For records: the reason we care about this is that if we keep a real kit name in the yaml example, then when we eventually run this api against the real ag database, someone might run the api with the example inputs and screw up the data for a real kit that belongs to a real AGP participant.