search

biocore / oecophylla

shotgun pipeline
MIT License
11 stars 19 forks source link

Fixes to Distance module #103

Closed tanaes closed 6 years ago

tanaes commented 6 years ago

Discovered some errors when running wet test on Barnacle. Fixed, and made a few small changes to organization---primarily merging mash.rule and sourmash.rule into distance.rule.

This follows PR #102, so we should merge that first?

@RNAer @qiyunzhu

tanaes commented 6 years ago

Thanks!

RNAer commented 6 years ago

This is very minor. I thought we would like to keep each tool in its own rule file? I am ok with current organization in the PR if it is consistent.

Shall we start to migrate the changes from dev to master?

tanaes commented 6 years ago

This is more consistent with what we have in the other modules currently. I could see an argument for having a single module rule file that imported the top-level rules from each tool rule file though.

On Wed, Oct 4, 2017 at 3:39 PM Zech Xu notifications@github.com wrote:

This is very minor. I thought we would like to keep each tool in its own rule file? I am ok with current organization in the PR if it is consistent.

Shall we start to migrate the changes from dev to master?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/biocore/oecophylla/pull/103#issuecomment-334266711, or mute the thread https://github.com/notifications/unsubscribe-auth/AH6JAFttjnTomasRNoEv2TI59cNFDzVjks5so97ZgaJpZM4Ps25h .

qiyunzhu commented 6 years ago

Perhaps I wasn't involved in previous discussions, but I would rather all tools under one module (e.g., "taxonomy") merged into one conda environment. Otherwise you will have 20+ envs.

RNAer commented 6 years ago

agree, but i am talking about the rule file not env. That being said, I am ok either way. good to merge

On Wed, Oct 4, 2017 at 1:25 PM, Qiyun Zhu notifications@github.com wrote:

Perhaps I wasn't involved in previous discussions, but I would rather all tools under one module (e.g., "taxonomy") merged into one conda environment. Otherwise you will have 20+ envs.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/biocore/oecophylla/pull/103#issuecomment-334278611, or mute the thread https://github.com/notifications/unsubscribe-auth/AA9CeDZyT4WbbSZwXd6KoeSErfuyivSBks5so-mngaJpZM4Ps25h .

tanaes commented 6 years ago

awesome, if one of you doesn't mind merging that would be great! Thanks!

On Wed, Oct 4, 2017 at 6:15 PM Zech Xu notifications@github.com wrote:

agree, but i am talking about the rule file not env. That being said, I am ok either way. good to merge

On Wed, Oct 4, 2017 at 1:25 PM, Qiyun Zhu notifications@github.com wrote:

Perhaps I wasn't involved in previous discussions, but I would rather all tools under one module (e.g., "taxonomy") merged into one conda environment. Otherwise you will have 20+ envs.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/biocore/oecophylla/pull/103#issuecomment-334278611, or mute the thread < https://github.com/notifications/unsubscribe-auth/AA9CeDZyT4WbbSZwXd6KoeSErfuyivSBks5so-mngaJpZM4Ps25h

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/biocore/oecophylla/pull/103#issuecomment-334305237, or mute the thread https://github.com/notifications/unsubscribe-auth/AH6JAAQSxO53QOLbV3b7ICfgcdP1A8uoks5spAN2gaJpZM4Ps25h .