biocore / oecophylla

shotgun pipeline
MIT License
11 stars 19 forks source link

added SHOGUN functional profiling #116

Closed qiyunzhu closed 7 years ago

qiyunzhu commented 7 years ago

@tanaes @mortonjt

qiyunzhu commented 7 years ago

Note that the oecophylla self test won't pass, because the minimal function db is not present yet. I need to talk with Gabe and Ben to figure that out.

qiyunzhu commented 7 years ago

Also please note that in the beginning of function.rule, I imported parser.py from the taxonomy directory. This may not be the most clean way. Plus, I further thought that maybe we don't need Python in combining tables, but some simple Bash commands will do:

echo $'#OTU ID\tA\tB' > combined.tsv
join -j1 -e'0' -a1 -a2 -o 0,1.2,2.2 <(tail -n+2 A.txt | sort) <(tail -n+2 B.txt | sort) -t$'\t' >> combined.tsv
biom convert --to-hdf5 -i combined.tsv -o combined.biom

@sjanssen2 what do you think?

tanaes commented 7 years ago

I'd much prefer the python, personally---easier to understand / maintain / unit test.

wasade commented 7 years ago

Agree

On Oct 9, 2017 2:37 PM, "Jon Sanders" notifications@github.com wrote:

I'd much prefer the python, personally---easier to understand / maintain / unit test.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/biocore/oecophylla/pull/116#issuecomment-335297571, or mute the thread https://github.com/notifications/unsubscribe-auth/AAc8smRFzU5CvSIB31RNduFbO1XcNf4Bks5sqpIIgaJpZM4Py-Eo .

qiyunzhu commented 7 years ago

@tanaes and @wasade thanks for your comments!