Shogun version update - Githubissues

biocore / oecophylla

shotgun pipeline

MIT License

11 stars 19 forks source link

Shogun version update #160

Closed tanaes closed 6 years ago

tanaes commented 6 years ago

This updates the shogun version to:

be explicit (1.0.5), so should be robust to further github/conda versioning
take advantage of the new pathway summarization functionality
add pathway compatibility to test db

@qiyunzhu this modifies your original code, would you mind sanity checking (and maybe installing + testing on your own barnacle install?)

qiyunzhu commented 6 years ago

@tanaes Sorry for the late reply. This looks quite sane to me. It is good to know that they now have five catagories: 'kegg', 'modules', 'modcov', 'pathways', 'pathcov'. But they didn't do 'kegcov'. Therefore, I guess 'kegg' means relative abundance, does it?

tanaes commented 6 years ago

'kegg' is the per-gene annotation, so the 'coverage' concept doesn't apply.

tanaes commented 6 years ago

@qiyunzhu ok to merge?

qiyunzhu commented 6 years ago

@tanaes Got it! Merged.