Open wasade opened 10 years ago
retest this please
Travis doesn't listen to retest comments unfortunately. To have this retested, click "Details" and hit the refresh button that's towards the top right of the screen.
ahh, thanks
there isn't a refresh there
@ElBrogrammer, travis is confused over the repo name change. this is a low prio pull right now as we don't yet have any hdf5 code in use though, just trying to clean out PRs
probably b/c pyqi was moved from the bipy org to biocore
Found the new link to this PR on Travis. I went ahead and restarted the tests:
Thanks. One failure, which isn't surprising as HDF5 should be considered an optional dependency here. Do you know how to get nosetests to not execute tests if an optional dependency is missing?
On Wed, Mar 19, 2014 at 11:34 AM, Jai Ram Rideout notifications@github.comwrote:
Found the new link to this PR on Travis. I went ahead and restarted the tests:
https://travis-ci.org/biocore/pyqi/builds/15857676
Reply to this email directly or view it on GitHubhttps://github.com/biocore/pyqi/pull/244#issuecomment-38082313 .
Not sure for nose, but you might add conditional unit tests that are skipped if h5py isn't present:
http://docs.python.org/3.1/library/unittest.html#skipping-tests-and-expected-failures
this PR got really weird conflicts that ive never seen before. right now, through mechanisms i don't understand, this PR is now blocked by py33
Want to close this one and reissue?
suspect it'll be fine once py33 is merged
we really need to avoid long outstanding PRs, though i know it is difficult to get some of these merged at times and to get effort on them
On Wed, Mar 19, 2014 at 12:22 PM, Jai Ram Rideout notifications@github.comwrote:
Want to close this one and reissue?
Reply to this email directly or view it on GitHubhttps://github.com/biocore/pyqi/pull/244#issuecomment-38088056 .
Added support so we can automatically and implicitly resize hdf5 datasets. This is in support of the pending updates to the split libraries workflow