biocore / pyqi

Tools for developing and testing command line interfaces in Python.
Other
9 stars 13 forks source link

python 3.4+ #268

Closed wwood closed 8 years ago

wwood commented 8 years ago

Hi,

Currently installation of pyqi through pip fails if the version of python is 3.4+, because the version is artificially restricted in setup.py

# Verify Python version
ver = '.'.join(map(str, [sys.version_info.major, sys.version_info.minor]))
if ver not in ['2.7', '3.3', '3.4']:
    sys.stderr.write("Only Python 2.7, 3.3, and 3.4 are supported.")
    sys.exit(1)

Would it be possible to remove this restriction? Are there any known issues for 3.4 or 3.5?

Thanks, ben

wwood commented 8 years ago

Oh my mistake, I just came across https://github.com/biocore/pyqi/issues/263 where 3.4 support is now official and the setup.py has changed accordingly. Would you mind making a new release? Is 3.5 supported?

wwood commented 8 years ago

heh, 3.4 is even in my code copy/paste above.

wasade commented 8 years ago

@wwood, this repository is being phased out in favor of click. I'd be happy to merge a PR for a fix on this, but just know that we will not be actively adding in new features.

wwood commented 8 years ago

ok, maybe a disclaimer in the README would be helpful.

gregcaporaso commented 8 years ago

I agree. I'll do this now.

gregcaporaso commented 8 years ago

see #269

wwood commented 8 years ago

thanks.