search

biocore / q2-qemistree

Hierarchical orderings for mass spectrometry data. Canonically pronounced "chemis-tree".
BSD 2-Clause "Simplified" License
32 stars 16 forks source link

Add QC module #129

Open anupriyatripathi opened 4 years ago

anupriyatripathi commented 4 years ago

..to compare classyfire output for features with both ms2 and csi smiles

lfnothias commented 4 years ago

@anupriyatripathi Note that most GNPS libraries and NIST were used for the training of CSIFingerID. so it should be identical in all cases, but it doesn't prove anything on the accuracy, just that the pipeline is consistent.

anupriyatripathi commented 4 years ago

@lfnothias Note that this issue will not test the accuracy of CSI:FingerID on library spectra but on real data

lfnothias commented 4 years ago

I think that's fine as a sanity check. But if an experimental spectrum matches a library spectrum then are very similar to each other, so this is still an overfitting problem, so one has to interpret that with care.