search

biocore / q2-qemistree

Hierarchical orderings for mass spectrometry data. Canonically pronounced "chemis-tree".
BSD 2-Clause "Simplified" License
31 stars 16 forks source link

Qc fps #76

Closed anupriyatripathi closed 4 years ago

anupriyatripathi commented 5 years ago

this PR changes qc_properties to False as the default. To reduce false positive merges in fingerprints, we should keep all fingerprint positions (total 2936)

ElDeveloper commented 5 years ago

Changes look good to me, I am a bit surprised that there's no tests failing after these changes any ideas? Or are we always specifying whether or not to do the qc filtering?

anupriyatripathi commented 4 years ago

Currently, we are always specifying whether or not to QC in the tests & only checking if that filtering works correctly when specified. We can add another one that uses the default.

ElDeveloper commented 4 years ago

Got it, that makes a lot of sense.