biocore / q2-qemistree

Hierarchical orderings for mass spectrometry data. Canonically pronounced "chemis-tree".
BSD 2-Clause "Simplified" License
31 stars 16 forks source link

Tree fixes (Critical) #99

Closed anupriyatripathi closed 4 years ago

anupriyatripathi commented 4 years ago

This PR addresses a critical bug introduced by the previous merge (id 60c312f67456e2df44ccf87a74532e71aa884071) which lead to NaNs in the classified feature data output of get-classyfire-taxonomy when Classyfire returned an empty classification string. This causes errors when trying to render the tree in iToL using _itol_metadata.py. I have fixed this by replacing NaNs with "unclassified"