MAINT/TST: dependency version cap; "fix" broken bootstrapped p-value test

biocore / qiime

Official QIIME 1 software repository. QIIME 2 (https://qiime2.org) has succeeded QIIME 1 as of January 2018.

GNU General Public License v2.0

285 stars 268 forks source link

Closed jairideout closed 8 years ago

jairideout commented 8 years ago

QIIME 1 is now in maintenance mode, so capping dependency versions that we don't control to avoid future breakage (e.g., in unit tests).

Fixes #2078.

jairideout commented 8 years ago

Before merging, verify the capped dependency versions are being tested against with Jenkins.

gregcaporaso commented 8 years ago

Good to merge when this passes (pending @jairideout's comment above).

ghost commented 8 years ago

Build results will soon be (or already are) available at: http://ci.qiime.org/job/qiime-github-pr/1710/

ghost commented 8 years ago

Build results will soon be (or already are) available at: http://ci.qiime.org/job/qiime-github-pr/1711/

jairideout commented 8 years ago

retest this please

ghost commented 8 years ago

Build results will soon be (or already are) available at: http://ci.qiime.org/job/qiime-github-pr/1712/

jairideout commented 8 years ago

retest this please

ghost commented 8 years ago

Build results will soon be (or already are) available at: http://ci.qiime.org/job/qiime-github-pr/1713/

jairideout commented 8 years ago

retest this please

ghost commented 8 years ago

Build results will soon be (or already are) available at: http://ci.qiime.org/job/qiime-github-pr/1714/

jairideout commented 8 years ago

@gregcaporaso this is ready for merge! I verified the correct dependency versions are being tested against.

gregcaporaso commented 8 years ago

Awesome! Thanks for wrapping it up - great to have the build finally back to passing!