search

biocore / qiime

Official QIIME 1 software repository. QIIME 2 (https://qiime2.org) has succeeded QIIME 1 as of January 2018.
GNU General Public License v2.0
286 stars 266 forks source link

improve doc for filter_fasta (--valid_states) #2151

Closed iugrina closed 8 years ago

iugrina commented 8 years ago

A simple improvement to filter_fasta doc to explain the format for valid_states.

ghost commented 8 years ago

Can one of the admins verify this pull request?

gregcaporaso commented 8 years ago

ok to test

ghost commented 8 years ago

Build results will soon be (or already are) available at: http://ci.qiime.org/job/qiime-github-pr/1722/

iugrina commented 8 years ago

@gregcaporaso Hi, the checks have failed which is quite strange since I've changed only one string in the doc part of the file :/

gregcaporaso commented 8 years ago

@iugrina, yes, this is unrelated. I'm going to rerun the tests anyway though (to see if it's a real issue or just a stochastic failure).

gregcaporaso commented 8 years ago

retest this please

ghost commented 8 years ago

Build results will soon be (or already are) available at: http://ci.qiime.org/job/qiime-github-pr/1723/

iugrina commented 8 years ago

@gregcaporaso merge?

gregcaporaso commented 8 years ago

Merged, thanks for the contribution (and the reminder) @iugrina!