search

biocore / qiime

Official QIIME 1 software repository. QIIME 2 (https://qiime2.org) has succeeded QIIME 1 as of January 2018.
GNU General Public License v2.0
286 stars 267 forks source link

create API documentation for MetadataMap class #752

Closed gregcaporaso closed 10 years ago

wasade commented 11 years ago

Agree this object would be valuable. On phone ATM but how similar/dissimilar is this obj to cogents Table?

On Mar 12, 2013, at 18:44, Greg Caporaso notifications@github.com wrote:

— Reply to this email directly or view it on GitHubhttps://github.com/qiime/qiime/issues/752 .

jairideout commented 11 years ago

MetadataMap is currently pretty dissimilar to cogent.util.table.Table, but it may be beneficial to inherit from that class. MetadataMap is basically a simple wrapper around the 2D dict returned by parse_mapping_file_to_dict, with some convenience methods needed by stuff in qiime.stats.

jairideout commented 11 years ago

@wasade, are there plans to have a discussion about core data structure classes that need to be added to QIIME (e.g. MetadataMap, DistanceMatrix, etc.)? If so, I'd like to hold off on modifications to the existing MetadataMap class until we determine what classes/functionality is needed.

Would it be useful if I create a milestone for these changes?

wasade commented 11 years ago

Ya, I thought the doc said greg was going to initiate the conversation?

On Mar 18, 2013, at 15:55, Jai Ram Rideout notifications@github.com wrote:

@wasade https://github.com/wasade, are there plans to have a discussion about core data structure classes that need to be added to QIIME (e.g. MetadataMap, DistanceMatrix, etc.)? If so, I'd like to hold off on modifications to the existing MetadataMap class until we determine what classes/functionality is needed.

Would it be useful if I create a milestone for these changes?

— Reply to this email directly or view it on GitHubhttps://github.com/qiime/qiime/issues/752#issuecomment-15084545 .

jairideout commented 11 years ago

Hmm... it's a little unclear in the doc who's going to initiate.

wasade commented 11 years ago

Says Greg + dev list, and that I will add in from there. I can initiate but do not want to replicate effort

On Mon, Mar 18, 2013 at 4:08 PM, Jai Ram Rideout notifications@github.comwrote:

Hmm... it's a little unclear in the doc who's going to initiate.

— Reply to this email directly or view it on GitHubhttps://github.com/qiime/qiime/issues/752#issuecomment-15085244 .

gregcaporaso commented 11 years ago

@wasade, if you want to initiate that's fine.

wasade commented 11 years ago

@gregcaporaso will draft initial email on this tonight/tomorrow and bounce off you before sending out to devs

jairideout commented 10 years ago

Closing since we're removing this class in favor of pandas data frames.