Closed gregcaporaso closed 10 years ago
MetadataMap
is currently pretty dissimilar to cogent.util.table.Table
, but it may be beneficial to inherit from that class. MetadataMap
is basically a simple wrapper around the 2D dict returned by parse_mapping_file_to_dict
, with some convenience methods needed by stuff in qiime.stats
.
@wasade, are there plans to have a discussion about core data structure classes that need to be added to QIIME (e.g. MetadataMap
, DistanceMatrix
, etc.)? If so, I'd like to hold off on modifications to the existing MetadataMap
class until we determine what classes/functionality is needed.
Would it be useful if I create a milestone for these changes?
Ya, I thought the doc said greg was going to initiate the conversation?
On Mar 18, 2013, at 15:55, Jai Ram Rideout notifications@github.com wrote:
@wasade https://github.com/wasade, are there plans to have a discussion about core data structure classes that need to be added to QIIME (e.g. MetadataMap, DistanceMatrix, etc.)? If so, I'd like to hold off on modifications to the existing MetadataMap class until we determine what classes/functionality is needed.
Would it be useful if I create a milestone for these changes?
— Reply to this email directly or view it on GitHubhttps://github.com/qiime/qiime/issues/752#issuecomment-15084545 .
Hmm... it's a little unclear in the doc who's going to initiate.
Says Greg + dev list, and that I will add in from there. I can initiate but do not want to replicate effort
On Mon, Mar 18, 2013 at 4:08 PM, Jai Ram Rideout notifications@github.comwrote:
Hmm... it's a little unclear in the doc who's going to initiate.
— Reply to this email directly or view it on GitHubhttps://github.com/qiime/qiime/issues/752#issuecomment-15085244 .
@wasade, if you want to initiate that's fine.
@gregcaporaso will draft initial email on this tonight/tomorrow and bounce off you before sending out to devs
Closing since we're removing this class in favor of pandas data frames.
Agree this object would be valuable. On phone ATM but how similar/dissimilar is this obj to cogents Table?
On Mar 12, 2013, at 18:44, Greg Caporaso notifications@github.com wrote:
— Reply to this email directly or view it on GitHubhttps://github.com/qiime/qiime/issues/752 .