search

biocore / qurro

Visualize differentially ranked features (taxa, metabolites, ...) and their log-ratios across samples
https://biocore.github.io/qurro
BSD 3-Clause "New" or "Revised" License
33 stars 10 forks source link

Add "Sample Presence Count" to Feature DataTables #266

Open gibsramen opened 4 years ago

gibsramen commented 4 years ago

As it stands, if you hover over features in the rank plot you get the Sample Presence Count and Current Ranking. It would be nice if this information were also visible in the data tables.

image

fedarko commented 4 years ago

Showing Sample Presence Count in the tables should be pretty doable, since this information is already pre-computed in the Python side of things (so showing it in the tables would just be a matter of modifying the way this data is stored in the JavaScript stuff).

However, showing Current Ranking in the tables would take a relatively large amount of work, weirdly enough. The reason is that these values can change for each feature when you change the currently selected ranking field in the rank plot. So in order to ensure that the tables are always accurate, this would require us to update the tables to reload this column of data whenever the ranking field is changed -- and that's achievable but would take some finagling to get right.

gibsramen commented 4 years ago

Gotcha. Honestly I think Sample Presence Count is the most important; Current Ranking, at least for what I envision most workflows would use, could be put on the backburner.

gibsramen commented 4 years ago

Going to break off Current Ranking into a separate issue given the widely different effort/priority of these two fields.