search

biocore / qurro

Visualize differentially ranked features (taxa, metabolites, ...) and their log-ratios across samples
https://biocore.github.io/qurro
BSD 3-Clause "New" or "Revised" License
33 stars 10 forks source link

Support not having an assigned color in sample plot #77

Open fedarko opened 5 years ago

fedarko commented 5 years ago

c/o lisa

fedarko commented 5 years ago

Would be doable by adding an invisible qurro_none option (with the text "Choose a color field..." or something) and making this the default in the colorField <select>, and I guess changing around some logic in (re)makeSamplePlot to see if this option is selected and (if so) don't bother using a color encoding at all. (We'd need to specifically exclude qurro_none from sample metadata cols via _df_utils.check_column_names(), etc.)

I'm thinking that this might be more trouble than it's worth to implement.