search

biocore / redbiom

Sample search by metadata and features
Other
44 stars 20 forks source link

Code inversion for ambiguities solving in fetch? #108

Closed cotillau closed 2 years ago

cotillau commented 3 years ago

In functions fetch_samples_from_obserations and fetch_samples_from_samples, there may be an inversion in the code when resolving ambiguities.

    if resolve_ambiguities == 'merge':
        tab = redbiom.fetch._ambiguity_keep_most_reads(tab, map_)
    elif resolve_ambiguities == 'most-reads':
        tab = redbiom.fetch._ambiguity_merge(tab, map_)
wasade commented 3 years ago

Can confirm -- good spot, thank you!