search

biocore / redbiom

Sample search by metadata and features
Other
45 stars 20 forks source link

Decouple #13

Closed wasade closed 7 years ago

wasade commented 7 years ago

Refactored commands, business logic pulled out allowing for API access and ease of unit tests. Latter is still deferred given the integration test harness, and because some of the load mechanisms will be changing to support tags.

wasade commented 7 years ago

Travis is stalled, created travis-ci/travis-ci#7242

wasade commented 7 years ago

I think I addressed them all, thanks @josenavas!

wasade commented 7 years ago

Want to just create a single issue to eval todos?

On Feb 1, 2017 7:34 AM, "Antonio Gonzalez" notifications@github.com wrote:

@antgonza commented on this pull request.

Code looks good, thanks! One question: there are 11 TODO lines, should this be issues? I personally like issues so those TODO don't get forgotten and also you can point to the issue in the line. @wasade https://github.com/wasade, what do you think?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/wasade/redbiom/pull/13#pullrequestreview-19576592, or mute the thread https://github.com/notifications/unsubscribe-auth/AAc8subyRgbLqTBj7zdDgN1SBAXNWOI6ks5rYKX1gaJpZM4Lxw4X .

antgonza commented 7 years ago

That also works even if less clear ... gonna merge but please open the issue.