biocore / redbiom

Sample search by metadata and features
Other
45 stars 20 forks source link

pypi updates #38

Closed wasade closed 7 years ago

wasade commented 7 years ago

Changes that were necessary to get the project to render properly on pypi. I've been able to verify that this works against https://testpypi.python.org, including grabbing the .tar.gz and performing a pip install -e . on it on a clean env on a system that I haven't used redbiom on. I was able to then query Qiita successfully (ie works out of the box). I could not pip install redbiom against testpypi as doing so forces dependency resolution to happen against testpypi which does not index pypi.

wasade commented 7 years ago

testpypi example, though note that testpypi cleans its index every 24h i think

wasade commented 7 years ago

True true...

On Jun 7, 2017 12:40, "Yoshiki Vázquez Baeza" notifications@github.com wrote:

@ElDeveloper commented on this pull request.

In setup.py https://github.com/biocore/redbiom/pull/38#discussion_r120725248:

class PostDevelopCommand(develop): """Post-installation for development mode.""" def run(self): develop.run(self) _post()

+# pypi does not render markdown. +# https://stackoverflow.com/a/26737672/19741 +try:

  • import pypandoc
  • long_description = pypandoc.convert('README.md', 'rst') +except(IOError, ImportError):
  • long_description = open('README.md').read()

There is not any other use that I know of.

Reasonable, but I think it would be good to hit the breaks even before uploading something that may need change, so as to facilitate the life of the release manage (who probably already is dealing with other stuff). If you don't think it makes any sense, this should be good then.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/biocore/redbiom/pull/38#discussion_r120725248, or mute the thread https://github.com/notifications/unsubscribe-auth/AAc8slPETCKPVH8wRzZ--HalIZTkiXV7ks5sBvy2gaJpZM4NzJJa .

ElDeveloper commented 7 years ago

👍 🎉