biocore / redbiom

Sample search by metadata and features
Other
45 stars 20 forks source link

Discrepancy between metadata search and stored metadata #40

Open wasade opened 7 years ago

wasade commented 7 years ago

When searching for burritos, @ElDeveloper discovered that none of the metadata (as obtained by redbiom fetch sample-metadata contained the stem burrito. On investigation, the issue is that the full metadata load (i.e., redbiom.admin.load_sample_metadata) omits the entire column of values if any entry contains a / character. This is because we communicate with Redis over URLs, and that is a very special character. In this case, the Description metadata column contained valid information and it was only a handful of entries which contained the / mark.

One possible solution: if the entry appears to be actual text and not numeric, remove the '/' mark and store the value. We cannot round trip with what was presented at load unfortunately.

What does need to be improved here though is consistency between what is found via search, and the metadata actually stored in redbiom.

wasade commented 1 year ago

Related to #9