search

biocore / redbiom

Sample search by metadata and features
Other
44 stars 20 forks source link

add md5 feature output for biom #84

Closed antgonza closed 5 years ago

wasade commented 5 years ago

Thanks! Can this logic be decomposed into a method in redbiom.util? Actually, do you think it would be better as an option to the underlying API method where if hash_ids is True, the IDs are hashed and the corresponding original ID is stored in the feature metadata? This way additional outputs don't need to be created, and the behavior is consistent whether interacting from the command line or Python API

antgonza commented 5 years ago
  1. Can this logic be decomposed into a method in redbiom.util?: Sure
  2. Do you think it would be better as an option to the underlying API method where if hash_ids is True, the IDs are hashed and the corresponding original ID is stored in the feature metadata?: To confirm, do you mean in the feature metadata in biom? If so, I rather have it as 2 outputs cause if in biom, AFAIK, there is no CLI way to recover those values in the feature metadata ...
wasade commented 5 years ago

Thanks!!