biocore / wetlab-assistant

BSD 3-Clause "New" or "Revised" License
0 stars 2 forks source link

Code comments #10

Open sjanssen2 opened 7 years ago

sjanssen2 commented 7 years ago

I don't know how I should leave comments for code merged into master, thus I open this list here (all regard plate_mapper.py):

qiyunzhu commented 7 years ago

Hi @sjanssen2 thanks for your very careful observation! Here are my answers to your questions: 1) This first cell does not always read "plate#\d+". It is actually a very arbitrary string for the plate name. They may write it as "fecal plate 001" or "best plate of the day". 2) The incremental order of column headers was ensured in line 40 elif int(v) != cols+1: and the raise error statement after it. The variable to store number of columns is cols. 3) @mortonjt also made this suggestion (using pandas). I will look into it. Thanks for yours!