Closed qiyunzhu closed 7 years ago
+1
On Wed, Feb 8, 2017 at 11:46 AM, Qiyun Zhu notifications@github.com wrote:
@qiyunzhu commented on this pull request.
In plate_mapper/plate_mapper.py https://github.com/biocore/wetlab-assistant/pull/14:
@@ -127,19 +134,22 @@ def plate_mapper(input_f, barseq_f, output_f, names_f=None, special_f=None):
[ barcode sequence, linker primer sequence, primer plate #, well ID ]
sample, property = '', [] if plate in plates:
- id = primer2plate[plate]
How about "pid" (plate ID)?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/biocore/wetlab-assistant/pull/14, or mute the thread https://github.com/notifications/unsubscribe-auth/AD_a3fqzH01Po96MZYAby4LNEpkR-cWCks5raht6gaJpZM4L6Oit .
+1
On Wed, Feb 8, 2017 at 11:45 AM, Qiyun Zhu notifications@github.com wrote:
@qiyunzhu commented on this pull request.
In plate_mapper/plate_mapper.py https://github.com/biocore/wetlab-assistant/pull/14:
@@ -127,19 +134,22 @@ def plate_mapper(input_f, barseq_f, output_f, names_f=None, special_f=None):
[ barcode sequence, linker primer sequence, primer plate #, well ID ]
sample, property = '', []
How about "metadata"?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/biocore/wetlab-assistant/pull/14, or mute the thread https://github.com/notifications/unsubscribe-auth/AD_a3TxrKZnpPVXydTf5l3eHsIU8TBjEks5rahtqgaJpZM4L6Oit .
@wasade @mortonjt Can we merge now?
Regex added. @mortonjt @wasade
Upon the requests from the wet lab crew, I modified two functions: 1) "plate ID" matters, in addition to the "primer plate ID". The plate name is the first cell of a plate (upper left most). It can be any string. The "ID" is identified as the trailing numeric part of this string (if any). For example, "plate 15", "Plate15", "plate #15", "Fecal plate 15" are all valid, and their IDs are all "15". This ID will be appended to the special samples (e.g., BLANK1.A1). This is to match the tradition of the wet lab. 2) For a special sample type, if its metadata is not defined in the special sample definition file (empty list), then the original metadata as defined in the plate map will be used. Please let me know if you have any comments. Thank you!
@wasade @mortonjt @josenavas @antgonza @sjanssen2