search

biocpp / biocpp-io

BioC++ Input/Output library
https://biocpp.github.io
BSD 3-Clause "New" or "Revised" License
8 stars 5 forks source link

[FEATURE] Add filedate to VCF file #30

Open Irallia opened 2 years ago

Irallia commented 2 years ago

This PR is a suggestion to add the filedate to the vcf. I have not yet customized the bcf tests. (I also haven't figured out how yet). There is no regulation about the format of the filedate, so I decided to use a readable format like ##fileDate=2022-03-02 14:18:22.

h-2 commented 2 years ago

Also regarding any future PRs:

This library has automatic code-formatting. You can cmake the tests/format folder and then run make check_library to check if your formatting is correct or make format_library to reformat the files to correct formatting, so you don't have to worry about any style-things.

Irallia commented 2 years ago

I like some of this, but I want to have a think about the general direction before progressing with this.

If file_date is important for you, I would propose to make a PR that just adds the member variable (empty by default) and nothing else. We could merge that right away, so you can set the string from your application?

Or we just keep this as a draft for now?

Since it's not a super important change for me, but rather a future wish, both options are okay for me.