search

biocro / biocro

https://biocro.github.io/
Other
41 stars 19 forks source link

Make R 4.0.0 instead of R 3.6.0 the minimum supported R version #67

Open gsrohde opened 9 months ago

gsrohde commented 9 months ago

Make R 4.0.0 instead of R 3.6.0 the minimum supported R version, and update the test workflow accordingly.

The package check passes on all platform + R version configurations except Windows with the Release version of R (see https://github.com/biocro/biocro/actions/runs/7198925592/job/19609456910). This is because of a failing harmonic oscillator test failure that @eloch216 alluded to earlier.

UPDATE: All checks passed in Run #163. This really is an intermittent bug.

justinmcgrath commented 9 months ago

Looks good. It would be nice to figure out the oscillator thing, but maybe for another day.

gsrohde commented 9 months ago

Converted to a draft while we consider merging PR #70 (which fixes a problem with the test of R 3.6.0) instead.

eloch216 commented 9 months ago

I guess we don't need to do this since PR #70 was merged?

gsrohde commented 9 months ago

I guess we don't need to do this since PR #70 was merged?

That is correct. My thought was to leave this here as a draft for if and when we decide to require R 4.0.0. I also just now added the "tabled for now" label.