search

biocypher / biochatter-server

Flask server for BioChatter integration into web apps
MIT License
0 stars 6 forks source link

[Debug] Without the app.log file, the app.py and the docker will exit #4

Closed xiaoranzhou closed 8 months ago

xiaoranzhou commented 9 months ago

[Debug] Without the app.log file, the app.py and the docker will exit

slobentanzer commented 8 months ago

@fengsh27 could you please check if this is fine to merge?

fengsh27 commented 8 months ago

Looks good

fengsh27 commented 8 months ago

@xiaoranzhou great work! I suggest adding a file called logs/placeholder instead of logs/app.log. This change will help prevent accidentally committing our own app.log to the repo. Additionally, please update .gitignore file to include logs/*.log.

slobentanzer commented 8 months ago

@fengsh27 @xiaoranzhou is this just about keeping the folder, i.e., the actual file is not important? If that is the case, I usually add a .gitkeep file, which has the same function as a placeholder would have, but is more self-explanatory as well as hidden.

fengsh27 commented 8 months ago

Yes, I believe it exited due to failing to write app.log to folder ./logs. In this case, .gitkeep is a better option.

xiaoranzhou commented 8 months ago

As this is under the scope of development, I will close this issue. 😄

slobentanzer commented 8 months ago

@xiaoranzhou you also closed the PR, was that your intent?

xiaoranzhou commented 8 months ago

Yes, this will be solved by using empty folder and .gitkeep right 😄 ? So I closed it.

slobentanzer commented 8 months ago

You also changed some logic in the conversation manager in this PR

slobentanzer commented 8 months ago

Also, why not implement the .gitkeep solution in this PR and then merge?

xiaoranzhou commented 8 months ago

I added this quick and dirty solution to make sure biochatter-server run. 😄 The wasm was relying the biochatter-server. If biochatter-server does not run, you will not be able to test the wasm part. Now I have changed the wasm part to make it independent of the biochatter-server. So I will only get back to the biochatter-server, when you finshed the debug.

There are currently also other issues with the port setting the respons format. Maybe finish "port" and "respons" first.

slobentanzer commented 8 months ago

Agree re the port, we should address #2. What is the response issue? I am not sure I know that one. Can we create an issue?

xiaoranzhou commented 8 months ago

https://github.com/biocypher/biochatter-server/issues/6 created, I will add more debug information after the wasm merge finished 😄