search

biocypher / biochatter-server

Flask server for BioChatter integration into web apps
MIT License
0 stars 6 forks source link

Typo in constant #7

Open slobentanzer opened 8 months ago

slobentanzer commented 8 months ago

https://github.com/biocypher/biochatter-server/blob/b4c761927353e800be0dd4370199c060d56ca13a/src/constants.py#L11

@fengsh27 same questions here, is the typo problematic, and does the constant need to be the same as the port (i.e., do we need to update this to 5001)?

fengsh27 commented 8 months ago

No, this code is just error code and not used as port.

slobentanzer commented 8 months ago

OK, thanks for clarifying. Would probably be good to fix the typo.

Is the 5000 code a convention, or is this randomly selected?

fengsh27 commented 8 months ago

I will fix it in next submission. 5000 is random selection : )

slobentanzer commented 7 months ago

Hi @fengsh27, this is still unfixed, could be good to do on the side in one of the next feature additions.

slobentanzer commented 3 months ago

@fengsh27 reminder that we could get rid of these minor TODOs in the next update

slobentanzer commented 1 month ago

@fengsh27 is this fixed?