biod / sambamba

Tools for working with SAM/BAM data
http://thebird.nl/blog/D_Dragon.html
GNU General Public License v2.0
565 stars 105 forks source link

Error: Implicit string concatenation is deprecated #363

Closed sjackman closed 6 years ago

sjackman commented 6 years ago

I see the following error when compiling Sambamba 0.6.7 with LDC 1.10.0.

sambamba/depth.d(1154): Error: Implicit string concatenation is deprecated, use "mapping_quality > 0 and " ~ "not duplicate and " instead
sambamba/depth.d(1155): Error: Implicit string concatenation is deprecated, use "not duplicate and " ~ "not failed_quality_control" instead

See https://circleci.com/gh/brewsci/homebrew-bio/3878 and https://github.com/brewsci/homebrew-bio/pull/405

pjotrp commented 6 years ago

Thanks. Should not be hard to fix ;)

sjackman commented 6 years ago

Thanks, Pjotr!

sjackman commented 6 years ago

Do you expect 0.6.8 to fix this issue?

pjotrp commented 6 years ago

Yes. You can check out git master to test.

sjackman commented 6 years ago

Thanks! I'm looking forward to the release of 0.6.8.