biodavidjm / artMS

Analytical R Tools for Mass Spectrometry
GNU General Public License v3.0
14 stars 7 forks source link

Minor issue in artms_getMSstatsFormat default parameters, future bug maybe #167

Closed bpolacco closed 3 years ago

bpolacco commented 4 years ago

Check out the default parameter list for the current .artms_getMSstatsFormat below, in particular data_object=data_object. If this is called without passing in a value for data_object, this will fail. This is an internal function only, so not particularly dangerous as coded, but may be a future headache for somebody. I propose declaring it as data_object = FALSE to be consistent with its only calling function at this point: artMSQuantification.

.artms_getMSstatsFormat <- function(data_f, 
                                    fraction, 
                                    output_name, 
                                    funfunc = "sum",
                                    data_object = data_object,
                                    verbose = TRUE) {
biodavidjm commented 3 years ago

Done! Thanks Ben!