biodiversitydata-se / biocollect

Biocollect front end application for Bioatlas
https://biocollect.biodiversitydata.se/
Other
0 stars 0 forks source link

an admin can't delete a draft - maybe the drafts should be deleted after a while ? #207

Closed mathieuLU closed 2 years ago

mathieuLU commented 2 years ago

A question after the problem you encountered. Surveys that are saved as draft, or not approved, block the import from the excel tool.

What should we do with these surveys ? Delete them automatically ? ("not approved" should be deleted ?) Delete then after a while ? ("draft" can maybe be deleted several days after creation ?)

mathieuLU commented 2 years ago

Now the intranet tool ignores the activities with status "not verified" or "draft". So it's possible to import a survey from excel even if someone already started to create a draft on that route.

mathieuLU commented 2 years ago

OK so the drafts can remain drafts as long as the users wants to keep them

and it's possible to remove the "not approved" surveys. It's fine, we can close it.

mathieuLU commented 2 years ago

test version, example of a non-approved survey that can be deleted by an admin

Screenshot from 2022-01-26 18-23-50

ekol-ali commented 2 years ago

Sounds good Mathieu.

But the four surveys that you deleted for us earlier today, never showed up anywhere. Did you change something now that would have made them visible for us before?

Åke

Från: mathieuLU @.> Skickat: Wednesday, 26 January 2022 18:25 Till: biodiversitydata-se/biocollect @.> Kopia: Åke Lindström @.>; Assign @.> Ämne: Re: [biodiversitydata-se/biocollect] an admin can't delete a draft - maybe the drafts should be deleted after a while ? (Issue #207)

test version, example of a non-approved survey that can be deleted by an admin

[Bild som tagits bort av avsändaren. Screenshot from 2022-01-26 18-23-50]https://user-images.githubusercontent.com/50901365/151214540-4f5d76a5-623d-4cea-a43e-6a6f38929b07.png

— Reply to this email directly, view it on GitHubhttps://github.com/biodiversitydata-se/biocollect/issues/207#issuecomment-1022421784, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AXBWL5VKCHSQWG2JRNFVWYDUYAU7VANCNFSM5M3AZK5A. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you were assigned.Message ID: @.***>

mathieuLU commented 2 years ago

They were drafts. Never submitted by the user. Do you want to be able to see them ?

ekol-ali commented 2 years ago

Hej Mathieu, hoppas du mår bättre idag.

Hm, it was obvious this time that we needed to be able to see and delete these drafts. On the other hand, we don’t want drafts to be exported with submitted protocols. Solution?

Åke

Från: mathieuLU @.> Skickat: Wednesday, 26 January 2022 18:37 Till: biodiversitydata-se/biocollect @.> Kopia: Åke Lindström @.>; Assign @.> Ämne: Re: [biodiversitydata-se/biocollect] an admin can't delete a draft - maybe the drafts should be deleted after a while ? (Issue #207)

They were drafts. Never submitted by the user. Do you want to be able to see them ?

— Reply to this email directly, view it on GitHubhttps://github.com/biodiversitydata-se/biocollect/issues/207#issuecomment-1022432250, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AXBWL5XIJYUSPYPAPHFFLV3UYAWNFANCNFSM5M3AZK5A. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you were assigned.Message ID: @.***>

mathieuLU commented 2 years ago

the drafts aren't exported!

they are visible only for the users. They are not extracted with the intranet-tool (am I wrong ?) the main problem was that they were not filtered from the import-excel function

ekol-ali commented 2 years ago

Background: A surveyor tries three times to report a survey in BioCollect. (S)he fails and gives up. The three failed attempts are still there as drafts. (S)he sends an Excel-file instead! Now, the main problem for us was that these draft survey reports prevented us from importing the full and correct report from the Excel sheet. Apparently the route/year combination was understood by the import function to be already existing.

Does that make sense?

Åke

Från: mathieuLU @.> Skickat: Thursday, 27 January 2022 16:32 Till: biodiversitydata-se/biocollect @.> Kopia: Åke Lindström @.>; Assign @.> Ämne: Re: [biodiversitydata-se/biocollect] an admin can't delete a draft - maybe the drafts should be deleted after a while ? (Issue #207)

the drafts aren't exported!

they are visible only for the users. They are not extracted with the intranet-tool (am I wrong ?) the main problem was that they were not filtered from the import-excel function

— Reply to this email directly, view it on GitHubhttps://github.com/biodiversitydata-se/biocollect/issues/207#issuecomment-1023338444, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AXBWL5U3WTDGPVSWZLKLMJ3UYFQQZANCNFSM5M3AZK5A. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you were assigned.Message ID: @.***>