search

biodiversitydata-se / biocollect

Biocollect front end application for Bioatlas
https://biocollect.biodiversitydata.se/
Other
0 stars 0 forks source link

Find a person => many null rows in the result list #212

Closed mathieuLU closed 2 years ago

mathieuLU commented 2 years ago

Admin => Hitta en person => "mathieu" => screenshot removed

Admin => rapportera resultat => screenshot removed

mathieuLU commented 2 years ago

the first one is fixed screenshot removed

mathieuLU commented 2 years ago

the second one as well. fixed ! screenshot removed

mathieuLU commented 2 years ago

fixed with https://github.com/biodiversitydata-se/biocollect/commit/6f196ff3fa8cda0c23e3c7604e684c8c8c82b255

ekol-ali commented 2 years ago

Sounds good! I tried several searches but didn't get any "null null". However, when I searched a personId, in ths case myself, I also got STEFAN PETERSON !!!

screenshot removed

Also when searching my friend Ulf, another guy turned up (guess who)! Quite amazing!

screenshot removed

mathieuLU commented 2 years ago

i locked the conversation (i did not know the option exists). It's good to do it before attaching data that could contain personal info. I removed the screenshots from the previous messages as well

mathieuLU commented 2 years ago

I spent the day to work with elasticsearch, finally ! I understand a lot more of it now, even if there are still a lot of unknown areas... I cannot go in details for setting up the search functions so far. But at least I understand why STEFAN PETERSON is in the list every time we search for a personnr that ends with "-1"

depending on what you have entered, it's split in blocks to search through different fields. When you search "610814-1", it's split in 2 blocks, because of the "-". and it appears that Stefan has an email address that ends with "-1" ! The content of the fields in the database are split as well. Which means that we have a matching result with this -1 and his email address ;-)

We can't consider it as a bug. From my point of view it's fine to leave it this way ;-) What do you think ? Please reopen if you think we should change this behavior

ekol-ali commented 2 years ago

Ah, interesting, and always good to get a logic explanation to strange things. Obviously not a bug, just a coincidence! Just leave it there!

Åke

Från: mathieuLU @.> Skickat: Tuesday, 8 February 2022 16:52 Till: biodiversitydata-se/biocollect @.> Kopia: Åke Lindström @.>; Assign @.> Ämne: Re: [biodiversitydata-se/biocollect] Find a person => many null rows in the result list (Issue #212)

I spent the day to work with elasticsearch, finally ! I understand a lot more of it now, even if there are still a lot of unknown areas... I cannot go in details for setting up the search functions so far. But at least I understand why STEFAN PETERSON is in the list every time we search for a personnr that ends with "-1"

depending on what you have entered, it's split in blocks to search through different fields. When you search "610814-1", it's split in 2 blocks, because of the "-". and it appears that Stefan has an email address that ends with "-1" ! The content of the fields in the database are split as well. Which means that we have a matching result with this -1 and his email address ;-)

We can't consider it as a bug. From my point of view it's fine to leave it this way ;-) What do you think ? Please reopen if you think we should change this behavior

— Reply to this email directly, view it on GitHubhttps://github.com/biodiversitydata-se/biocollect/issues/212#issuecomment-1032760366, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AXBWL5VGHFNKQGMU7R2Z3KTU2E33JANCNFSM5NLQQ4BA. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you were assigned.Message ID: @.***>