search

bioelectric-interfaces / nfb_studio

NFB experiment designer.
https://bioelectric-interfaces.github.io/nfb_studio/
1 stars 0 forks source link

Visual connection of nodes #10

Closed aksiotis closed 3 years ago

aksiotis commented 3 years ago

After importing a file where a composite signal was added, lines between basic signals and composite one are missing. It could be misleading for users. image

bindreams commented 3 years ago

Sorry for a late fix, composite signals will now be connected to derived signals whose name is in the expression. Unfortunately this is not a perfect fix, since if you have signals Signal and Signal1, and an expression Composite = Signal1, both derived signal names will be found in the text and both will be connected. To implement a more robust check we need to find some kind of math expression library, which can identify variables in an expression.

Speaking of which, some kind of expression builder is also needed for the composite signal export UI to create syntactically correct expressions, and only with the signals that are allowed (connected). So I will keep this issue open until a proper fix is implemented.

bindreams commented 3 years ago

Expression parsing has been implemented. I'll open a separate issue for the UI changes.